Make creases and flaps first-class entities in Fold_state (#26, #27) #40

Merged

toph merged 8 commits from feat/crease-entity into main 2026-07-03 07:16:56 +00:00

Conversation 0 Commits 8 Files changed 31 +3166 -137

toph commented 2026-07-03 06:35:57 +00:00

Owner

Copy link

For #26 and #27. Groundwork for the #26/#28 material-crease work, split into two PRs; this is PR1, the plumbing.

Makes creases and flaps first-class entities in Fold_state: an edge carries paper endpoints, its two bordering face ids, an assignment, a stable crease_id, and provenance. Edges accumulate across folds and split when a later fold crosses them, preserving crease_id — the #26 identity invariant. fold_emit now serializes creases straight from state.edges, retiring the emit-time geometric reconstruction (the record_of/on_segment chord matching). The #27 precrease bug — mark a crease, fold on it, get U/0° instead of V/180° — is now fixed on the entity via an in-place U→M/V upgrade; the old tactical two-chords-at-emit hack and the now-dead crease_record side-list are removed, so edges are the single source of truth.

Behavior-preserving. A 20-snapshot golden net, generated on the old emit path, survives the rewrite byte-for-byte — no emitted FOLD changes. Rebased onto the step/macro slice (#35); fold_state.ml was untouched by it, so the entity work rebased clean and the goldens were regenerated to characterize #35 output.

Out of scope, deferred to PR2: material crease reference semantics and the #(.a .b .c) flap operand — the user-facing half of #28. This PR is only the entity that PR2 builds on; no language surface changes here. Design and plan live in docs/superpowers/{specs,plans}/2026-07-03-*.

For #26 and #27. Groundwork for the #26/#28 material-crease work, split into two PRs; this is PR1, the plumbing. Makes creases and flaps first-class entities in `Fold_state`: an `edge` carries paper endpoints, its two bordering face ids, an assignment, a stable `crease_id`, and provenance. Edges accumulate across folds and split when a later fold crosses them, preserving `crease_id` — the #26 identity invariant. `fold_emit` now serializes creases straight from `state.edges`, retiring the emit-time geometric reconstruction (the `record_of`/`on_segment` chord matching). The #27 precrease bug — mark a crease, fold on it, get `U`/0° instead of `V`/180° — is now fixed on the entity via an in-place `U`→`M`/`V` upgrade; the old tactical two-chords-at-emit hack and the now-dead `crease_record` side-list are removed, so edges are the single source of truth. Behavior-preserving. A 20-snapshot golden net, generated on the old emit path, survives the rewrite byte-for-byte — no emitted FOLD changes. Rebased onto the step/macro slice (#35); `fold_state.ml` was untouched by it, so the entity work rebased clean and the goldens were regenerated to characterize #35 output. Out of scope, deferred to PR2: material crease reference semantics and the `#(.a .b .c)` flap operand — the user-facing half of #28. This PR is only the entity that PR2 builds on; no language surface changes here. Design and plan live in `docs/superpowers/{specs,plans}/2026-07-03-*`.

toph added 8 commits 2026-07-03 06:35:58 +00:00

test(golden): characterization snapshots of example FOLD output ... 9b323226e9

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jfw5BuRgc2vq3j6zckY867

feat(fold-state): first-class edge entity + face adjacency (#26) ... 73b385f40c

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jfw5BuRgc2vq3j6zckY867

test(fold-state): cover edge remapping — disambiguation, mountain, subdivide, flip d8bd8822e7

test(golden): regenerate snapshots against #35 main (def/apply/step syntax + step provenance field) ... 200f7e7f44

Rebased feat/crease-entity onto origin/main (7d353f2, step-macro slice #35).
#35 added a 'step' field to beloch:edges and rewrote example syntax, changing
the FOLD output of every crease-bearing example; def-diagonals.bel is new.
fold_state.ml (Task 2) untouched by #35 — rebased clean, 5/5 fold_state green.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jfw5BuRgc2vq3j6zckY867

refactor(fold): accumulate+split edges across folds; emit from state, drop chord reconstruction (#26) ... 4e38bfdf80

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jfw5BuRgc2vq3j6zckY867

test(fold): oracle+unit coverage for #27 precrease upgrade (V/180 on the entity) 6e625fee47

refactor(fold): drop crease_record side-list; edges are the single source of truth (#26) ea972ec7e8

docs: add #26/#28 spec + PR1 plan to the branch (self-documenting); fix golden count 18→20 ... cc6cb5139c

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Jfw5BuRgc2vq3j6zckY867

toph merged commit 802671b90d into main 2026-07-03 07:16:56 +00:00

toph deleted branch feat/crease-entity 2026-07-03 07:16:57 +00:00

toph referenced this pull request from a commit 2026-07-03 07:16:57 +00:00

Make creases and flaps first-class entities in Fold_state (#26, #27) (#40)

toph referenced this pull request 2026-07-03 09:54:34 +00:00

Make named creases material; add flap operands (#28) #43

toph referenced this pull request from a commit 2026-07-03 10:50:43 +00:00

Make named creases material; add flap operands (#28) (#43)

toph referenced this pull request 2026-07-04 19:06:41 +00:00

design: first-class topology in Fold_state (pocket-slice prerequisite) #26

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

toph/beloch!40

No description provided.