Fold-scope follow-ups: at_matches error ownership, fold provenance golden, grammar naming #68

New issue

Open

opened 2026-07-05 10:52:20 +00:00 by toph · 0 comments

toph commented

2026-07-05 10:52:20 +00:00

Owner

Three small follow-ups from the fold-scope review (#67), none merge-blocking:

The at 0-match/multi-match error texts are duplicated across three call sites (resolve_line, resolve_flap_face, target_of in eval.ml) — at_matches should own the failure so the texts cannot drift.
No golden exercises "axiom": "fold" provenance on a freshly-cut segment — both @fold examples fold along existing edges only. A @fold where a moving flap straddles the axis beyond the crease's material extent would land it.
Spec Appendix-A names the point|line|#(…) union flap_operand, while parser.mly's flap_operand nonterminal is only the #(…) form (the union is flap_arg) — rename the spec production.

Three small follow-ups from the fold-scope review (#67), none merge-blocking: - [ ] The `at` 0-match/multi-match error texts are duplicated across three call sites (`resolve_line`, `resolve_flap_face`, `target_of` in `eval.ml`) — `at_matches` should own the failure so the texts cannot drift. - [ ] No golden exercises `"axiom": "fold"` provenance on a freshly-cut segment — both `@fold` examples fold along existing edges only. A `@fold` where a moving flap straddles the axis beyond the crease's material extent would land it. - [ ] Spec Appendix-A names the point|line|`#(…)` union `flap_operand`, while `parser.mly`'s `flap_operand` nonterminal is only the `#(…)` form (the union is `flap_arg`) — rename the spec production.

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

toph/beloch#68

No description provided.

Rows
Columns